[ 
https://issues.apache.org/jira/browse/FELIX-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763347#comment-15763347
 ] 

Carsten Ziegeler commented on FELIX-5404:
-----------------------------------------

I agree with this as well as I tried to explain above.

However, the patch does not change this behaviour - if at build time the 
property elements are generated everything is fine, regardless whether the 
patch is applied or not. But I think the code in general is more complete (not 
sure if that is the right word) if the helper method reverts to the default 
values of the annotation.

> Annotation configurations default values are not considered
> -----------------------------------------------------------
>
>                 Key: FELIX-5404
>                 URL: https://issues.apache.org/jira/browse/FELIX-5404
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-2.0.6
>            Reporter: Julian Sedding
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: scr-2.1.0
>
>         Attachments: FELIX-5404-integration-test-jsedding.patch, 
> FELIX-5404-jsedding.patch
>
>
> When an annotation is used to configure an SCR component (as per DS 1.3), the 
> annotation's default values are not considered.
> This can lead to the odd situation that an annotation method with a default 
> value returns null. I'm not sure if this violates a contract or another, 
> however, my IDE complains when I do a null check.
> I think it would be the right thing to do to return the default value if no 
> value is explicitly configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to