[
https://issues.apache.org/jira/browse/FELIX-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890403#comment-15890403
]
ASF GitHub Bot commented on FELIX-5574:
---------------------------------------
GitHub user xfournet opened a pull request:
https://github.com/apache/felix/pull/95
FELIX-5574 change Windows default os name from win to win32
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xfournet/felix FELIX-5574
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit fe9bfcbdb7c01980a2949051b67d412f0ce4fb6a
Author: xfournet <[email protected]>
Date: 2017-03-01T15:37:36Z
FELIX-5574 Windows default os name from win to win32
----
> When detecting an unknow Windows OS name, provides a suitable default value
> for org.osgi.framework.os.name
> ----------------------------------------------------------------------------------------------------------
>
> Key: FELIX-5574
> URL: https://issues.apache.org/jira/browse/FELIX-5574
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Xavier Fournet
> Priority: Minor
> Fix For: framework-5.6.4
>
>
> When the system property os.name return a Windows OS name that is not
> recognized by
> org.apache.felix.framework.util.manifestparser.NativeLibraryClause#normalizeOSName
> then it return "win" as a fallback value.
> However this "win" value is not something valid for the
> org.osgi.framework.os.name property name (cf
> https://www.osgi.org/developer/specifications/reference/)
> Changing the fallback value to "win32" would be better so it would allow most
> of the JNI library to be loaded.
> This would allow smooth support of future windows platform, for example for
> Windows Server 2016 with JDK9 (or JDK8 when
> https://bugs.openjdk.java.net/browse/JDK-8159948 will be fix on it)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
