Should be change the ImmutableList in the same manner ? It should have a minimal impact on memory as it's main use in in the BundleWiringImpl class afaik and I don't expect many empty wirings, but it can't hurt...
2017-03-26 21:53 GMT+02:00 Karl Pauls <[email protected]>: > Done in r1788773. > > regards, > > Karl > > On Sun, Mar 26, 2017 at 9:39 PM, Karl Pauls <[email protected]> wrote: > > As mentioned on the issue - it looks like it makes more sense to do > > the check in the ImmutableMap#newInstance. I'll move it there and > > close our pull request. Thanks for the patch! > > > > regards, > > > > Karl > > > > 2017-03-26 20:27 GMT+02:00 Jean-Baptiste Onofré <[email protected]>: > >> Hi > >> > >> I gonna take a look. > >> > >> Regards > >> JB > >> > >> On Mar 26, 2017, 19:34, at 19:34, Fabian Lange < > [email protected]> wrote: > >>>Gets rid of plenty of empty maps in my case: > >>>https://github.com/apache/felix/pull/97/files > >>> > >>>Fabian > >>>-- > >>>Fabian Lange | Performance Expert > >>>mobil: +49 (0) 160.3673393 > >>> > >>>codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland > >>> > >>>Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal > >>>Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns > >>>Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen > >>>Schütz > > > > > > > > -- > > Karl Pauls > > [email protected] > > > > -- > Karl Pauls > [email protected] > -- ------------------------ Guillaume Nodet
