+1 (binding) from my side. (many thanks for your votes)
regards Pierre On Sat, Jul 1, 2017 at 6:19 PM, Pierre De Rop <[email protected]> wrote: > Thanks Jan Willem for the feedbacks; > > - For the index.html.tmp file, can you please open a jira issue and > indicate in it which option you used to ignore the tmp file ? (I guess it's > "--reject=html,txt,tmp" ?); > and it's odd because I don't see any tmp files from > https://dist.apache.org/repos/dist/dev/felix/org.apache > .felix.dependencymanager-r11/ ?; > > - for the gogo shell, you indeed need to update to the latest gogo > version, because the version for the org.apache.felix.gogo.runtime bundle > has been bumped, and the dm shell depends on it. > As said in FELIX-5650, I could not manage to stay compatible with previous > gogo versions, and if it required to use the previous (non-jline) gogo > version, then in this case please use the dm shell from previous DM-R9 > version. > > - for FELIX-5660 where you need to build the annotations before other > bundles, it's an old issue, I will ask on bndtools mailing list if there is > a solution for this problem, and it is currently indicated in > https://svn.apache.org/repos/asf/felix/trunk/dependencyma > nager/release/resources/src/README.src that you indeed need to first > build the annotation jar before building all other bundles. > > thanks & regards > Pierre > > > > On Thu, Jun 29, 2017 at 11:08 AM, Jan Willem Janssen < > [email protected]> wrote: > >> Hi, >> >> > On 27 Jun 2017, at 09:17, Pierre De Rop <[email protected]> wrote: >> > >> > Hello all, >> > >> > After a failed attempt to release the DM-R10 release, I would like to >> call >> > for a new vote on the Dependency Manager toplevel release R11. >> > >> > The following issues were solved: >> > >> > ** Bug >> > * [FELIX-5630] - NullObject is created for a required dependency if >> the >> > component is removed and added again to the dependency manager >> > * [FELIX-5636] - Component of aspect service does not have any >> service >> > properties anymore >> > * [FELIX-5657] - DM released sources can't be rebuilt >> > >> > ** Improvement >> > * [FELIX-5619] - MultiProperyFilterIndex memory consumption >> > * [FELIX-5623] - Improve performance of ComponentImpl.getName method >> > * [FELIX-5650] - Support latest version of Gogo >> > * [FELIX-5653] - Simplify DM-Lambda samples >> > * [FELIX-5658] - Include poms in dm artifacts >> > >> > You can use this UNIX script to download the release and verify the >> > signatures: >> > >> > >> > http://svn.apache.org/repos/asf/felix/trunk/dependencymanage >> r/release/check_staged_release.sh >> > >> > Usage: >> > >> > sh check_staged_release.sh r11 /tmp/felix-staging >> > >> > This script, unlike the original Felix check_stage_release.sh, is >> specific >> > to the new Dependency Manager release process (see FELIX-4818) and will >> > download staging from https://dist.apache.org/repos/dist/dev/felix >> instead >> > of http://repository.apache.org/content/repositories. >> > >> > To rebuild the DM binaries from the source, you can then refer to >> > https://svn.apache.org/repos/asf/felix/trunk/dependencymanag >> er/release/resources/src/README.src >> > >> > >> > Please vote to approve this release: >> > >> > [ ] +1 Approve the release >> > [ ] -1 Veto the release (please provide specific comments) >> >> The verification of the signatures had a small hiccup: there’s a >> `index.html.tmp` file >> present in the staging directory which breaks the signature check. >> Updating the script >> to also exclude `.tmp` files causes the verification to be successful. >> >> Did try the new DM bundles in a local project, which works, apart from >> the shell: you >> need to upgrade to the latest Gogo shell in order to make use of it. Not >> sure why this >> is needed yet. >> >> Building the release from sources is successful on the 2nd run after a >> clean: the first >> time, the build fails with the exception that the annotation processor >> cannot be found. >> The build is successful after re-running the build again. >> I’ve created FELIX-5660 for that. >> >> No showstoppers for me, so +1 on the release. >> >> -- >> Met vriendelijke groeten | Kind regards >> >> Jan Willem Janssen | Software Architect >> +31 631 765 814 >> >> >> My world is something with Amdatu and Apache >> >> Luminis Technologies >> John F. Kennedylaan 32 >> 7314 PS Apeldoorn >> +31 88 586 46 25 >> >> https://www.luminis.eu >> >> KvK (CoC) 09 16 28 93 >> BTW (VAT) NL8170.94.441.B.01 >> >> >
