[
https://issues.apache.org/jira/browse/FELIX-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211124#comment-16211124
]
Brandan Jeter edited comment on FELIX-5686 at 10/19/17 2:28 PM:
----------------------------------------------------------------
[~gnt]: I do not believe this is fully resolved. The NullPointerException is
fixed, but that whole block of code that handles the Delete event is dead code.
When it tries to get the configuration from ConfigAdmin, it will never get the
actual config because the actual config was already deleted. So files in etc
are never going to be properly deleted. How should I properly report this?
Should I reopen the initial improvement ticket?
https://issues.apache.org/jira/browse/FELIX-5610 Or create a bug ticket?
was (Author: brandan.jeter):
[~gnt]: I do not believe this is fully resolved. The NullPointerException is
fixed, but that whole block of code that handles the Delete event is dead code.
When it tries to get the configuration from ConfigAdmin, it will never get the
actual config because the actual config was already deleted. How should I
properly report this? Should I reopen the initial improvement ticket?
https://issues.apache.org/jira/browse/FELIX-5610
> NPE in ConfigInstaller on ConfigDelete
> --------------------------------------
>
> Key: FELIX-5686
> URL: https://issues.apache.org/jira/browse/FELIX-5686
> Project: Felix
> Issue Type: Bug
> Affects Versions: fileinstall-3.6.0
> Reporter: Brandan Jeter
> Assignee: Guillaume Nodet
> Fix For: fileinstall-3.6.4
>
>
> The ConfigInstaller is handling a Config Delete Event now, but it always
> throws a NullPointException which crowds up the logs.
> On delete, the ConfigInstaller tries to get the corresponding Configuration
> object:
> https://github.com/apache/felix/blob/trunk/fileinstall/src/main/java/org/apache/felix/fileinstall/internal/ConfigInstaller.java#L176
> It's never going to get the Configuration object because it was just deleted.
> So the getConfiguration call creates a new one with null as the properties.
> Then on line 180 there is a NullPointerException.
> Unfortunately, the fix for this will require changing the
> ConfigurationListener API so that the ConfigurationEvent either has the whole
> Dictionary of configuration properties or at least the felix.file.install
> property, if it exists.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
