[ 
https://issues.apache.org/jira/browse/FELIX-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617315#comment-16617315
 ] 

Christian Schneider edited comment on FELIX-5924 at 9/17/18 9:57 AM:
---------------------------------------------------------------------

To be honest I would not use placeholders in default config values.

Instead what I had in mind was to be able to override any config value using an 
env variable. So the syntax would be like:
 export my.pid.mykey=myvalue

So the syntax would be <pid>.<key> maybe also with something different than "." 
to make sure we clearly can split into pid and key.

These overrides should then be merged with the default values before applying 
the defaults to make sure the config is written only once.

 


was (Author: [email protected]):
To be honest I would not use placeholders in default config values.

Instead what I had in mind was to be able to override any config value using an 
env variable. So the syntax would be like:
export my.pid.mykey=myvalue

These overrides should then be merged with the default values before applying 
the defaults to make sure the config is written only once.

 

> Allow to provide/override config key values using env variables
> ---------------------------------------------------------------
>
>                 Key: FELIX-5924
>                 URL: https://issues.apache.org/jira/browse/FELIX-5924
>             Project: Felix
>          Issue Type: Bug
>          Components: Configurator
>    Affects Versions: configurator-1.0.4
>            Reporter: Christian Schneider
>            Priority: Major
>             Fix For: configurator-1.0.6
>
>
> The old configurer allowed to override key/values using env variables. This 
> is very suitable when depolying using docker as it is a standard approach 
> there.
> I propose we also support this for configurator. The data provided in env 
> should override eventual default configs provided inside bundles. 
> If possible we should make sure that the config is still only created once so 
> services do not oscilate.
> With some pointers I might  be able to provide a PR for this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to