[ 
https://issues.apache.org/jira/browse/FELIX-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617850#comment-16617850
 ] 

Tom Rutchik commented on FELIX-5913:
------------------------------------

Karl,

I submitted a pull request for Felix Android Support.  The pull request has 
documentation that explains the changes made; it turns out to be  pretty 
straight forward and not a lot of code change.  I was able to streamline my 
first attempts at getting the implementation to work, and I'm pretty satisfied 
with the results.  It's passing all of my test cases.  I also discovered that I 
my previous implementation attempt did not support native code correctly. This 
version now support native code correctly according to the OSGI specification 
and the use of the Bundle-NativeCode header.  Again, the documentation I 
attached to the pull requests explains all of these in better detail.

One benefit of this implementation is that dexified bundles don't need to 
include the ".java" files, only the classes.dex.  In the 5.6.10 release, you 
got some kind of error if they weren't present, even though they aren't really 
used. That always bothered me, because it basically doubles the footprint size 
of bundles that ran on Android. If a bundle does contains both the ".java" 
files and the classes.dex file, then that same bundle works on both a Java and 
Dalvik VM. 

- Tom Rutchik


> Support Android
> ---------------
>
>                 Key: FELIX-5913
>                 URL: https://issues.apache.org/jira/browse/FELIX-5913
>             Project: Felix
>          Issue Type: Wish
>          Components: Framework
>    Affects Versions: framework-6.0.0, framework-6.0.1
>            Reporter: Tom Rutchik
>            Priority: Major
>         Attachments: BundleWiringImpl.java, 
> FelixAndroidSupportImplementationNotes.pdf
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> The lastest 6.0.0 and 6.0.1 release no longer works on Android.
> The code form the 5.6.10 version necessary to make it work was not ported 
> into these versions.
> Some code needs to be added to the class BundleWiringImpl class to allow for 
> android support. All of the code necessary to due that can be found in the 
> 5.6.10 version.
> I've added the code and have tested it and it's working fine again.  I've 
> attached an implementation of BundleWiringImpl that works with android. It's 
> basically the 6.0.1 implementation with the extra code from 5.6.10.  You 
> should be able to do a file diff on the 6.0.1 to see where I had to add the 
> missing code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to