On Tue, Sep 18, 2018 at 1:02 AM Carsten Ziegeler <[email protected]> wrote:
> Hi Ray, > > > the name property and the below framework property have been introduced > at the same time. The assumption here is, if you use named PMs, then you > specify that property to select the right one. And vice versa of course, > if you specify the property, you have to name your PMs. > > You mention that you specify that property but don't specify a name for > your PM. In that case I think the behaviour is correct. > No, what I mean is that when not specifying a name, there is no tracker created at all. - Ray > > I'm all for enhancing the docs around it, but atm I fail to see that > this is a breaking change. > > Regards > Carsten > > Raymond Auge wrote > > Hey all, > > > > I've just tried upgrading to the latest ConfigAdmin and found that the > > persistence manager stuff has a breaking change. > > > > Reading the code I see the following comment indicating that things > should > > work as previously: > > > > /** > > * The name of the framework context property defining the > persistence > > * manager to be used. If not specified, the old behaviour is used > > * and all available pms are used > > * > > * @see #start(BundleContext) > > */ > > private static final String CM_CONFIG_PM = "felix.cm.pm"; > > > > However, that's not true. If I don't specify a _name_ service property > for > > my custom persistence manager AND configure this framework property with > > that name, NO tracker is ever created, let alone started, which means NO > > external persistence managers are ever tracked. > > > > As it seems we've moved quite far along with this implementation I'd at > > least request that the documentation and this comment be updated to > > indicate that custom persistence managers are ONLY configurable through > the > > above framework property. > > > > I'm very sorry that I didn't catch this in review :( > > > > Sincerely, > > > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected] > -- *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> (@rotty3000) Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> (@Liferay) Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
