[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750716#comment-16750716
]
Guillaume Nodet edited comment on FELIX-6034 at 1/24/19 4:46 AM:
-----------------------------------------------------------------
The effectiveness is controlled by the {{ResolveContext#isEffective}} method.
What you describe is only the default implementation of the osgi framework at
runtime, not the resolver spec.
If this requirement is _literally disabled for all intents and purposes,_ then
simply removing it should not affect anyone either, but it will allow Karaf to
upgrade until a minor version includes this breaking change.
If the plan is to include more requirements like this one in the future, that's
ok, but not in micro releases to avoid such compatibility break.
was (Author: gnt):
The effectiveness is controlled by the {{ResolveContext#isEffective}} method.
What you describe is only the default implementation of the osgi framework at
runtime, not the resolver spec.
If this requirement is _literally disabled for all intents and purposes,_ then
simply removing it should not affect anyone either, but it will allow Karaf to
upgrade until a minor version includes this breaking change.
> Gogo JLine requirement doesn't allow to embed gogo.jline
> --------------------------------------------------------
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
> Affects Versions: gogo.jline-1.1.2
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
