I think it is unnecessary overhead for the user to add two dependencies when he wants to create a check. The annotations do not have to be exported. So they would be neutral from the bundle view of the api.
Christian Am Do., 31. Jan. 2019 um 17:07 Uhr schrieb Georg Henzler <fe...@ghenzler.de >: > Hi Christian, > > So the health check annotations are only needed at build time by the > bnd-maven-plugin, whereas the API bundle is required at runtime. It > would of course work in one bundle (and people using it would only have > to add one dependency in their pom instead of two), but on the other > hand it's somewhat cleaner to have the two aspects separate (we had it > the same way in Sling). If we really see a problem with it we can always > change it later. > > -Georg > > On 2019-01-31 16:31, Christian Schneider wrote: > > I think the annotations of felix health check should be part of the > > api. > > So I propose to add them to the api project and remove the annotations > > bundle. > > > > WDYT? > > Christian > > -- > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
