[ 
https://issues.apache.org/jira/browse/FELIX-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved FELIX-5995.
-------------------------------------
    Resolution: Fixed

Actually after revisiting the javadocs for HttpService.unregister I think the 
test case is wrong. The javadoc says:
If the bundle which performed the registration is stopped or otherwise
 "unget"s the Http Service without calling {@link #unregister(String)}
 then Http Service must automatically unregister the registration.
 However, if the registration was for a servlet, the {@code destroy}
 method of the servlet will not be called in this case since the bundle
 may be stopped

So when the jetty bundle is stopped, destroy must not be called. I've corrected 
the test case

> HttpService HttpServiceController should stop whiteboardManager before 
> httpServicefactory
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-5995
>                 URL: https://issues.apache.org/jira/browse/FELIX-5995
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http.jetty-4.0.6, http.base-4.0.4, http.bridge-4.0.4
>            Reporter: Karl Pauls
>            Assignee: Karl Pauls
>            Priority: Major
>             Fix For: http.base-4.0.6, http.jetty-4.0.8, http.bridge-4.0.6
>
>
> The HttpServiceController does in the register method start the 
> httpServiceFactory and then the whiteboardManager. In the unregister method, 
> it does stop the httpServiceFactory and then the whiteboardManager. That 
> creates a problem as the whiteboardManager needs a started httpServiceFactory 
> when services come in. 
> The fix should be simple, we should stop the whiteboardManager before we stop 
> the httpServiceFactory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to