👍 On Fri, Jul 26, 2019 at 10:20 AM David Bosschaert < [email protected]> wrote:
> While Carsten reviewed the code earlier today he suggested that this > mechanism be supported, so the plugin is registered with a > config.plugin.id > value of 'org.apache.felix.configadmin.plugin.interpolation' [1] > > Thanks for the review, Carsten! > > David > > [1] > > https://github.com/apache/felix/blob/trunk/configadmin-plugins/interpolation/src/main/java/org/apache/felix/configadmin/plugin/interpolation/Activator.java#L44 > > On Fri, 26 Jul 2019 at 15:02, Raymond Auge <[email protected]> > wrote: > > > Perfect (I didn't look at the impl), but as long as there's a way to > > enforce it! :) > > > > - Ray > > > > On Fri, Jul 26, 2019 at 9:58 AM Carsten Ziegeler <[email protected]> > > wrote: > > > > > Not sure, if that's what you're looking for, but with FELIX-6059 you > can > > > configure the configuration admin to depend on the plugin being > available > > > > > > Carsten > > > > > > Raymond Auge wrote > > > > An idea for the future might be a requirement so that we can make > sure > > > the > > > > feature is available during provisioning of the framework bundles. > > > > > > > > - Ray > > > > > > > > On Fri, Jul 26, 2019 at 7:12 AM David Bosschaert < > > > [email protected]> > > > > wrote: > > > > > > > >> Thanks for the suggestion, Bertrand! > > > >> > > > >> I have renamed the plugin to 'interpolation'. > > > >> I have also implemented framework/system property based substitution > > as > > > >> suggested by JB Onofré > > > >> And I have added substitution support for environment variables, > which > > > can > > > >> be useful when you'd like to configure your runtime (e.g. > containers) > > > >> 12-factor style > > > >> > > > >> The code is here: > > > >> > > > >> > > > > > > https://svn.apache.org/repos/asf/felix/trunk/configadmin-plugins/interpolation > > > >> Documentation is best read on github: > > > >> > > > >> > > > > > > https://github.com/apache/felix/blob/trunk/configadmin-plugins/interpolation/README.md > > > >> > > > >> I'd like to do an initial 0.0.2 release early next week to make it > > easy > > > for > > > >> everyone to try it out. > > > >> > > > >> Any suggestions, let me know! > > > >> > > > >> Cheers, > > > >> > > > >> David > > > >> > > > >> > > > >> On Fri, 26 Jul 2019 at 10:06, Bertrand Delacretaz < > > > [email protected]> > > > >> wrote: > > > >> > > > >>> Hi, > > > >>> > > > >>> On Thu, Jul 25, 2019 at 4:32 PM David Bosschaert > > > >>> <[email protected]> wrote: > > > >>>> ...I was thinking of putting it at > > configadmin-plugins/substitution.. > > > >>> > > > >>> FWIW, "interpolation" is a common term for that as per > > > >>> https://en.wikipedia.org/wiki/String_interpolation > > > >>> > > > >>> -Bertrand > > > >>> > > > >> > > > > > > > > > > > -- > > > Carsten Ziegeler > > > Adobe Research Switzerland > > > [email protected] > > > > > > > > > -- > > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> > > (@rotty3000) > > Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> > > (@Liferay) > > Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> > > (@OSGiAlliance) > > > -- *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> (@rotty3000) Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> (@Liferay) Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
