tjwatson commented on issue #1: WIP: FELIX-6228: Atomos maven plugin
URL: https://github.com/apache/felix-atomos/pull/1#issuecomment-594529419
 
 
   > Thank you.
   > But I am not sure why Graal-NI could not handle this.
   > [oracle/graal#1956](https://github.com/oracle/graal/issues/1956)
   
   I'm not sure that issue is related here.  The issue isn't that we need to 
use a URLClassLoader to find the resources.  During native-image compilation 
substrate will not automatically include all available resources from the JARs 
on the classpath.  I *think* this is motivated by trying to keep the image as 
small as possible and there is no easy way for the compiler to know all the 
resources that are necessary for the subset of code that is getting compiled 
into the image.  So it is expected that you configure the resources you know 
are necessary.  Here we know the webconsole loads up these files from 
`templates/` and `res/`.  But I don't know how you know that in an automated 
general way.
   
   I'm not sure how useful it is to trim out unused resources.  One option 
would be to just have the plugin discover all resources from the bundle JARs 
and put a pattern for all of them.  It will result in slightly larger images, 
but I doubt it will be that big as long as we limit it to the resources from 
the bundle JARs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to