amitjoy commented on a change in pull request #11: [FELIX-6246] Packaged
External Library Packages inside referenced Health Check Bundles
URL: https://github.com/apache/felix-dev/pull/11#discussion_r399644195
##########
File path: healthcheck/webconsoleplugin/bnd.bnd
##########
@@ -1,10 +1,6 @@
-Bundle-Category: healthcheck
-
-Bundle-Description: ${project.description}
-
-Bundle-DocURL: https://felix.apache.org
-
-Bundle-License: Apache License, Version 2.0
-
-Bundle-Vendor: The Apache Software Foundation
-
+Bundle-Category : healthcheck
+Bundle-Description : ${project.description}
+Bundle-DocURL : https://felix.apache.org
+Bundle-License : Apache License, Version 2.0
+Bundle-Vendor : The Apache Software Foundation
+-conditionalpackage : org.apache.commons.lang3.*
Review comment:
Actually an embedded use case comprises both production-ready and
developer-friendly gateways. I agree with you that such a web console bundle is
not relevant for a production ready gateway but it is definitely required for
developers in the development phase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
