glimmerveen commented on a change in pull request #19:
URL: https://github.com/apache/felix-dev/pull/19#discussion_r413552250
##########
File path:
scr/src/main/java/org/apache/felix/scr/impl/manager/DependencyManager.java
##########
@@ -2239,52 +2238,16 @@ else if ( m_dependencyMetadata.getScope() ==
ReferenceScope.prototype_required )
m_componentManager.getLogger().log(LogService.LOG_DEBUG, "Setting
target property for dependency {0} to {1}",
null, getName(), target );
BundleContext bundleContext = m_componentManager.getBundleContext();
- Filter eventFilter = null;
Review comment:
I implemented this, but opted to use a different target in case of an
invalid one in the component definition, that is guaranteed to be never be
satisfied (inspiration drawn from the required capability in the osgi.cmpn API
bundle).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
