Hi, I saw the PR has been committed, it works fine. Thanks to all for having checked this old issue.
in case someone plan to propose a release, please hold on because I have another PR to submit. thanks & regards Pierre On Thu, Jun 11, 2020 at 7:22 AM Jean-Baptiste Onofre <[email protected]> wrote: > Hi, > > FYI it works fine in Karaf as we "wrap" gogo in Karaf console (with our > own activator). > > I will take a look on the PR (for "standalone" use). > > Regards > JB > > > Le 10 juin 2020 à 18:48, Pierre De Rop <[email protected]> a écrit > : > > > > Hi Arnoud, > > > > thanks ! indeed, adding the Activator makes all working fine. I guess we > > can now just merge your pull request ? > > > > thanks & regards > > /Pierre > > > > > > > > > > > > On Wed, Jun 10, 2020 at 6:03 PM Arnoud Glimmerveen < > [email protected]> > > wrote: > > > >> Hi Pierre, > >> > >> I believe this is due to a missing Bundle-Activator header. I have > opened > >> a PR [1] for this a couple of weeks ago, but this has not been picked up > >> yet. > >> > >> Best regards, > >> > >> Arnoud. > >> > >> [1] https://github.com/apache/felix-dev/pull/16 < > >> https://github.com/apache/felix-dev/pull/16> > >> > >>> On 10 Jun 2020, at 17:59, Pierre De Rop <[email protected]> > wrote: > >>> > >>> Hi all, > >>> > >>> I'm trying to run the latest gogo bundles which I have built from the > >>> master branch (using java8). So I have the following bundles in my > felix > >> 6.0.3 > >>> bundle directory: > >>> > >>> org.apache.felix.gogo.command-1.1.1-SNAPSHOT.jar > >>> org.apache.felix.gogo.jline-1.1.7-SNAPSHOT.jar > >>> org.apache.felix.gogo.runtime-1.1.3-SNAPSHOT.jar > >>> jline-3.13.2.jar > >>> jansi-1.17.1.jar > >>> > >>> But when starting felix, I don't see any gogo prompt, and nothing is > >>> displayed. > >>> > >>> What is the status of the gogo bundles in the master branch ? am I > >> missing > >>> something ? maybe some more bundles should now be added ? > >>> > >>> Note that if I replace org.apache.felix.gogo.jline-1.1.7-SNAPSHOT.jar > >>> by org.apache.felix.gogo.shell-1.1.3-SNAPSHOT.jar, then it works fine > >>> (either using java8 or java11). > >>> for example, using OpenJDK Runtime Environment (AdoptOpenJDK)(build > >>> 1.8.0_252-b09): > >>> > >>> java -jar bin/felix.jar > >>> ____________________________ > >>> Welcome to Apache Felix Gogo > >>> > >>> g! lb > >>> START LEVEL 1 > >>> ID|State |Level|Name > >>> 0|Active | 0|System Bundle (6.0.3)|6.0.3 > >>> 1|Active | 1|jansi (1.17.1)|1.17.1 > >>> 2|Active | 1|JLine Bundle (3.13.2)|3.13.2 > >>> 3|Active | 1|Apache Felix Bundle Repository (2.0.10)|2.0.10 > >>> 4|Active | 1|Apache Felix Gogo Command > >>> (1.1.1.SNAPSHOT)|1.1.1.SNAPSHOT > >>> 5|Active | 1|Apache Felix Gogo Runtime > >>> (1.1.3.SNAPSHOT)|1.1.3.SNAPSHOT > >>> 6|Active | 1|Apache Felix Gogo Shell > >>> (1.1.3.SNAPSHOT)|1.1.3.SNAPSHOT > >>> > >>> thanks & regards > >>> /pierre > >> > >> > >
