Hi Robert, sorry for the delay, but now I'm back on to this and after polishing, I'm planning to release everything within the next two weeks.
4. I was also surprised that I needed to create an executor for the 'Healthy' event to be registered. I thought that with the eventadmin requirement the services would be registered automatically, without me intervening.
So no instance of HealthCheckMonitor is active by default currently. Configuring one means that the tags as given will be regularly executed. To be exactly in line with systemready, you would configure an instance of HealthCheckMonitor with tag "systemready" and intervalInSec=5. Would you have expected that this config is done automatically for the case the event admin is present? (we definitely cannot start monitors for all checks by default, that would potentially be harmful)
3. I was a bit surprised that hc.core requires the Servlet API. The systemready bundle was a bit more lightweight.
systemready had the same dependency, just optional. I created FELIX-6289 to make it also optional for hc.core.
2. core build fails with pax-exam tests. Perhaps related to Java 11?
I checked this, it is indeed a Java 11 problem (just checked both 1.8 and 11). I'll check and fix.
1. api build fails due to the baselining check
this I could not reproduce. -Georg On 2020-04-21 13:53, Robert Munteanu wrote:
Hello Georg, Thanks for the implementation, looks good! I took it for a spin and for my scenario it works as expected. In addition to that. I have some notes that you may find useful. 1. api build fails due to the baselining check - org.apache.felix.hc.api.execution: Version increase required; detected 2.0.0, suggested 2.0.1 . 2. core build fails with pax-exam tests. Perhaps related to Java 11? ERROR: Bundle org.apache.felix.http.whiteboard [25] Error starting file:/tmp/1587396148625-0/pax-exam- downloads/org.apache.felix.http.whiteboard_4.0.0.jar (org.osgi.framework.BundleException: Unable to resolve org.apache.felix.http.whiteboard [25](R 25.0): missing requirement [org.apache.felix.http.whiteboard [25](R 25.0)] osgi.wiring.package; (&(osgi.wiring.package=org.osgi.service.http.context)(version>=1.1.0)(! (version>=2.0.0))) [caused by: Unable to resolve org.apache.felix.http.jetty [24](R 24.0): missing requirement [org.apache.felix.http.jetty [24](R 24.0)] osgi.wiring.package; (osgi.wiring.package=javax.annotation)] Unresolved requirements: [[org.apache.felix.http.whiteboard [25](R 25.0)] osgi.wiring.package; (&(osgi.wiring.package=org.osgi.service.http.context)(version>=1.1.0)(! (version>=2.0.0)))]) org.osgi.framework.BundleException: Unable to resolve org.apache.felix.http.whiteboard [25](R 25.0): missing requirement [org.apache.felix.http.whiteboard [25](R 25.0)] osgi.wiring.package; (&(osgi.wiring.package=org.osgi.service.http.context)(version>=1.1.0)(! (version>=2.0.0))) [caused by: Unable to resolve org.apache.felix.http.jetty [24](R 24.0): missing requirement [org.apache.felix.http.jetty [24](R 24.0)] osgi.wiring.package; (osgi.wiring.package=javax.annotation)] Unresolved requirements: [[org.apache.felix.http.whiteboard [25](R 25.0)] osgi.wiring.package; (&(osgi.wiring.package=org.osgi.service.http.context)(version>=1.1.0)(! (version>=2.0.0)))] 3. I was a bit suprised that hc.core requires the Servlet API. The systemready bundle was a bit more lightweight. 4. I was also suprised that I needed to create an executor for the 'Healthy' event to be registered. I thought that with the eventadmin requirement the services would be registered automatically, without me intervening. Anyway, the implementation works for me and I can support both systemready and health checks, which is great. Thanks! Robert
