ghenzler commented on pull request #29:
URL: https://github.com/apache/felix-dev/pull/29#issuecomment-653366854
Hi @amitjoy thanks for the contribution. Based on your PR I made the
following improvements in da6061d2d76b5926b77b82:
* I remove a lot of boilerplate classes (to keep it as minimal as possible
this will be good for IoT)
* I introduced support for 7th field year for at least `*`
** `*` could be easily supported because it is the same as omitting it, I
had an existing expression that was failing
** I removed the shortcut `@reboot` (because for that we would need proper
year field support, PR welcome)
* The class `EmbeddedCronParserTest` was using the deprecated Date
constructor, fixed that and moved all tests for `EmbeddedCronParser` into
`EmbeddedCronParserTest`
* The class `EmbeddedCronScheduler` is a lot simpler now and just uses the
JDK `ScheduledExecutorService` for without complicated wait/notify mechanics.
Everything is together on master now, please test with your setup if
everything works as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
