tjwatson commented on pull request #36: URL: https://github.com/apache/felix-dev/pull/36#issuecomment-670730031
It took me some time to start reviewing this. But my first question is about how OSGi LoggerFactory objects are obtained. With PR #27 I changed SCR to only use a single LoggerFactory using SCR's bundle context and then obtain Loggers on behalf of other bundles by using the method `org.osgi.service.log.LoggerFactory.getLogger(Bundle, String, Class<L>)` Unfortunately my changes in PR #27 broke the test case that Tim Ward provided such that it was not really testing properly. This allowed your changes to pass the test `org.apache.felix.scr.integration.Felix6274Test.test_incompatible_log_service_version()` when it should have gotten a cast exception. I am going to merge PR #40 to fix the test, but that then makes your changes fail the test. I think your changes would be more simple if you only had a single LoggerFactory obtained with the SCR context that you used to obtain all the OSGi Logger instances similar to how the code worked before. There should be no need to have complicated tracking of each LoggerFactory registration from the perspective of the component bundles. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
