amitjoy commented on a change in pull request #81:
URL: https://github.com/apache/felix-dev/pull/81#discussion_r674756330
##########
File path:
scr/src/main/java/org/apache/felix/scr/impl/inject/field/FieldHandler.java
##########
@@ -171,9 +171,9 @@ private boolean initField(final Object componentInstance,
return objects;
}
- private MethodResult updateField(final METHOD_TYPE mType,
- final Object componentInstance,
- final BindParameters bp)
+ private synchronized MethodResult updateField(final METHOD_TYPE mType,
Review comment:
I saw it coming 😉 Yes, you are right. The `synchronized` block was a bit
broader in this respect. We would be better off with synchronizing only the
part that requires it. I will do the needful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
