I think yeah. But there were changes not only in adm version, there were changes wich caused class manipulations to satisfy compiler requirements. If nothing will change there in future, then asm version upgrade will be enough i think.
пт, 11 мар. 2022 г., 19:03 Bengt Rodehav <be...@rodehav.com>: > That was quick! > > I tried it and it works. I guess asm 9.2.0 supports up to and including JDK > 18 - right? So in the future, just to keep iPojo compatible with new > versions of Java, will it suffice to just update the version of asm? > > /Bengt > > Den fre 11 mars 2022 kl 16:27 skrev Александр Шаклеин < > cheester...@gmail.com > >: > > > I have updated PR branch - increased asm - version for manipulator. > > I have tested build on OpenJDK 17 - it was successful. > > Have a try to test it. > > > > Regards, Alexander > > > > сб, 12 мар. 2022 г. в 00:35, Bengt Rodehav <be...@rodehav.com>: > > > > > OK - thanks. Please let me know when you have something you'd like me > to > > > test. > > > > > > /Bengt > > > > > > Den fre 11 mars 2022 kl 15:32 skrev Александр Шаклеин < > > > cheester...@gmail.com > > > >: > > > > > > > Ok. I see looks like a problem when using jdk higher than 11 when > > > building. > > > > Btw building with openJdk11 - is working > > > > I'll chek this problem later. > > > > > > > > сб, 12 мар. 2022 г. в 00:16, Bengt Rodehav <be...@rodehav.com>: > > > > > > > > > OK - I managed to build the important parts. However, using OpenJDK > > > 17, I > > > > > get the following build error: > > > > > > > > > > [ERROR] Failed to execute goal > > > > > org.apache.felix:maven-ipojo-plugin:1.12.2-SNAPSHOT:ipojo-bundle > > > > (default) > > > > > on project filetransfer-service: Execution default of goal > > > > > org.apache.felix:maven-ipojo-plugin:1.12.2-SNAPSHOT:ipojo-bundle > > > failed: > > > > > Unsupported class file major version 61 -> [Help 1] > > > > > > > > > > I use the plugin as follows: > > > > > > > > > > <plugin> > > > > > <groupId>org.apache.felix</groupId> > > > > > <artifactId>maven-ipojo-plugin</artifactId> > > > > > <version>1.12.2-SNAPSHOT</version> > > > > > <executions> > > > > > <execution> > > > > > <goals> > > > > > <goal>ipojo-bundle</goal> > > > > > </goals> > > > > > </execution> > > > > > </executions> > > > > > <dependencies> > > > > > <dependency> > > > > > <groupId>org.apache.felix</groupId> > > > > > > > <artifactId>org.apache.felix.ipojo.manipulator</artifactId> > > > > > <version>1.12.2-SNAPSHOT</version> > > > > > </dependency> > > > > > </dependencies> > > > > > </plugin> > > > > > > > > > > I'm not sure why I list the manipulator as a separate dependency. I > > > think > > > > > historically there have been times when a bug fix has been made in > > the > > > > > manipulator only - but I cannot remember anymore. > > > > > > > > > > /Bengt > > > > > > > > > > > > > > > Den fre 11 mars 2022 kl 13:10 skrev Bengt Rodehav < > be...@rodehav.com > > >: > > > > > > > > > > > Thanks Alexander - I'll try that. > > > > > > > > > > > > It turned out that my initial problem was that I was using > OpenJDK > > 17 > > > > for > > > > > > the build. When I changed to JDK 8 that error disappeared. But I > > > still > > > > > > can't get through the whole iPojo build because of the tests. I > > > suspect > > > > > > that the tests are made for Linux and I'm on Windows. > > > > > > > > > > > > But I'll see if it is enough with the manipulator project. > > > > > > > > > > > > /Bengt > > > > > > > > > > > > Den fre 11 mars 2022 kl 11:23 skrev Александр Шаклеин < > > > > > > cheester...@gmail.com>: > > > > > > > > > > > >> Hi all > > > > > >> > > > > > >> First as you can see in PR there were only made changes in > > > manipulator > > > > > >> project. > > > > > >> Proposed changes allow to use maven-ipojo-plugin when building > > > modules > > > > > >> with > > > > > >> jdk11+. > > > > > >> Besides after latest changes the same version now works on jdk8 > > and > > > > > jdk11+ > > > > > >> with no problems. > > > > > >> Speaking to me all what i was need to rebuild - is manipulator > > > > project. > > > > > >> Just got to folder felix-dev/ipojo/manipulator and execute > *maven > > > > clean > > > > > >> install* > > > > > >> Project successfully builds using jdk8 and jdk11. > > > > > >> (Btw, even if you build it using jdk8 it will properly work on > > > jdk11+) > > > > > >> > > > > > >> Regards, > > > > > >> > > > > > >> Alexander > > > > > >> > > > > > >> > > > > > >> пт, 11 мар. 2022 г. в 19:30, Bengt Rodehav <be...@rodehav.com>: > > > > > >> > > > > > >> > I am on Windows - hope it is possible to build iPojo on > Windows. > > > > > >> > > > > > > >> > /Bengt > > > > > >> > > > > > > >> > Den fre 11 mars 2022 kl 10:19 skrev Bengt Rodehav < > > > > be...@rodehav.com > > > > > >: > > > > > >> > > > > > > >> > > I downloaded the entire Felix code base for this commit. I > > then > > > > > >> attempted > > > > > >> > > to build iPojo with "mvn clean install" and got the > following > > > > error: > > > > > >> > > > > > > > >> > > [ERROR] Failed to execute goal > > > > > >> > > > > > > org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1:verify-legal-files > > > > > >> > > (default) on project org.apache.felix.ipojo.metadata: > > Execution > > > > > >> default > > > > > >> > of > > > > > >> > > goal > > > > > >> > > org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1:verify-legal-files > > > > > >> > > failed: Unable to make private > > > > > >> > java.io.File(java.lang.String,java.io.File) > > > > > >> > > accessible: module java.base does not "opens java.io" to > > > unnamed > > > > > >> module > > > > > >> > > @214e3185 -> [Help 1] > > > > > >> > > > > > > > >> > > I assume I built it the wrong way. Can anyone advise me how > to > > > > build > > > > > >> > Felix > > > > > >> > > (or just iPojo)? > > > > > >> > > > > > > > >> > > /Bengt > > > > > >> > > > > > > > >> > > Den ons 9 mars 2022 kl 15:55 skrev Bengt Rodehav < > > > > be...@rodehav.com > > > > > >: > > > > > >> > > > > > > > >> > >> I haven't done this before. I was hoping someone had newly > > > built > > > > > >> iPojo > > > > > >> > >> jar's I could test. > > > > > >> > >> > > > > > >> > >> /Bengt > > > > > >> > >> > > > > > >> > >> Den ons 9 mars 2022 kl 15:41 skrev Karl Pauls < > > > > karlpa...@gmail.com > > > > > >: > > > > > >> > >> > > > > > >> > >>> There is a PR here: > > > > https://github.com/apache/felix-dev/pull/129 > > > > > >> > >>> > > > > > >> > >>> So I imaging you would apply it locally and build the > ipojo > > > > > >> subproject. > > > > > >> > >>> > > > > > >> > >>> regards, > > > > > >> > >>> > > > > > >> > >>> Karl > > > > > >> > >>> > > > > > >> > >>> On Wed, Mar 9, 2022 at 3:27 PM Bengt Rodehav < > > > be...@rodehav.com > > > > > > > > > > >> > wrote: > > > > > >> > >>> > > > > > > >> > >>> > I can try. Not familiar with how to create a working JAR > > > from > > > > > the > > > > > >> > >>> > information in the JIRA though. Alexander, could you > build > > > the > > > > > >> > >>> necessary > > > > > >> > >>> > jar's for me and instruct me what dependencies I should > > use? > > > > > >> > >>> > > > > > > >> > >>> > /Bengt > > > > > >> > >>> > > > > > > >> > >>> > Den fre 4 mars 2022 kl 10:58 skrev Karl Pauls < > > > > > >> karlpa...@gmail.com>: > > > > > >> > >>> > > > > > > >> > >>> > > Yes, I agree - I didn't have time yet to review the > > path. > > > > > >> > >>> > > > > > > > >> > >>> > > Could you have a look and see if it is working for > you? > > > > > >> > >>> > > > > > > > >> > >>> > > regards, > > > > > >> > >>> > > > > > > > >> > >>> > > Karl > > > > > >> > >>> > > > > > > > >> > >>> > > On Fri, Mar 4, 2022 at 10:14 AM Bengt Rodehav < > > > > > >> be...@rodehav.com> > > > > > >> > >>> wrote: > > > > > >> > >>> > > > > > > > > >> > >>> > > > This is really interesting. We are very dependent on > > > iPojo > > > > > >> but we > > > > > >> > >>> need to > > > > > >> > >>> > > > move on to newer Java. We use OpenJDK 18 now. Even > if > > > > iPojo > > > > > >> won't > > > > > >> > >>> be > > > > > >> > >>> > > > maintained as in new features, it would be very > > valuable > > > > to > > > > > >> have > > > > > >> > >>> the > > > > > >> > >>> > > > existing functionality work in newer Java versions. > > > > > >> > >>> > > > > > > > > >> > >>> > > > /Bengt Rodehav > > > > > >> > >>> > > > > > > > > >> > >>> > > > Den fre 4 mars 2022 kl 07:06 skrev Alexander > Shaklein > > > > > (Jira) < > > > > > >> > >>> > > > j...@apache.org>: > > > > > >> > >>> > > > > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > [ > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > > > >> > >>> > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/FELIX-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > > > > >> > >>> > > > > ] > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > Alexander Shaklein updated FELIX-6502: > > > > > >> > >>> > > > > -------------------------------------- > > > > > >> > >>> > > > > Summary: IPOJO Java 11+ support (was: Java > 11+ > > > > > support) > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > IPOJO Java 11+ support > > > > > >> > >>> > > > > > ---------------------- > > > > > >> > >>> > > > > > > > > > > >> > >>> > > > > > Key: FELIX-6502 > > > > > >> > >>> > > > > > URL: > > > > > >> > >>> > > https://issues.apache.org/jira/browse/FELIX-6502 > > > > > >> > >>> > > > > > Project: Felix > > > > > >> > >>> > > > > > Issue Type: Improvement > > > > > >> > >>> > > > > > Components: iPOJO > > > > > >> > >>> > > > > > Reporter: Alexander Shaklein > > > > > >> > >>> > > > > > Priority: Minor > > > > > >> > >>> > > > > > > > > > > >> > >>> > > > > > I have made some changes in ipojo projects to > work > > > in > > > > > java > > > > > >> > 11+. > > > > > >> > >>> > > > > > The were successfully tested on java 11, 16. > > Should > > > i > > > > > >> make a > > > > > >> > >>> PR or i > > > > > >> > >>> > > can > > > > > >> > >>> > > > > work with fork alone? > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > -- > > > > > >> > >>> > > > > This message was sent by Atlassian Jira > > > > > >> > >>> > > > > (v8.20.1#820001) > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > > > >> > >>> > > > > > > > >> > >>> > > > > > > > >> > >>> > > -- > > > > > >> > >>> > > Karl Pauls > > > > > >> > >>> > > karlpa...@gmail.com > > > > > >> > >>> > > > > > > > >> > >>> > > > > > >> > >>> > > > > > >> > >>> > > > > > >> > >>> -- > > > > > >> > >>> Karl Pauls > > > > > >> > >>> karlpa...@gmail.com > > > > > >> > >>> > > > > > >> > >> > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > >
