HannesWell commented on PR #124:
URL: https://github.com/apache/felix-dev/pull/124#issuecomment-1106038538

   > I'm reviewing and testing this proposed change.
   
   > LGTM. NB: it would have been great to add a test to verify the metadata is 
cleanly generated.
   
   Thank you.
   Tests would indeed be good. But I wanted to discuss the technical details 
first to not (potentially) write tests unnecessarily. Unfortunately I have no 
time to look into that at the moment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to