[ https://issues.apache.org/jira/browse/FELIX-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539578#comment-17539578 ]
David Matějček commented on FELIX-6533: --------------------------------------- I updated the description; in the PR I extended the existing test (and moved that to appropriated place in relation to the new class) to cover this variant. > Felix released as milestone version cannot parse it's own version id > -------------------------------------------------------------------- > > Key: FELIX-6533 > URL: https://issues.apache.org/jira/browse/FELIX-6533 > Project: Felix > Issue Type: Bug > Components: Framework > Affects Versions: framework-7.0.3 > Reporter: David Matějček > Assignee: Karl Pauls > Priority: Blocker > Labels: patch-available, patch-with-test > Fix For: framework-7.0.4 > > Original Estimate: 4h > Remaining Estimate: 4h > > We tried to prerelease a custom built version for GlassFish, but it it not > able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to > 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed > in classifier. > h3. Cause > I found that it tries to "cleanup" the Maven version, but does it wrong and > then tries to parse the result again which fails. > *Solution* > I am creating PR right after this issue. Felix already has the correct > implementation usable for this, so I just moved it to the Version class > (which seems to be a natural place for this), updated all references and also > extended tests. It is backward compatible despite the bit of refactoring. -- This message was sent by Atlassian Jira (v8.20.7#820007)