chadlwilson commented on code in PR #154: URL: https://github.com/apache/felix-dev/pull/154#discussion_r882445269
########## framework/src/main/java/org/apache/felix/framework/cache/DirectoryContent.java: ########## @@ -48,16 +49,27 @@ public class DirectoryContent implements Content private final File m_rootDir; private final File m_dir; private Map m_nativeLibMap; + private final String m_canonicalRoot; public DirectoryContent(Logger logger, Map configMap, - WeakZipFileFactory zipFactory, Object revisionLock, File rootDir, File dir) + WeakZipFileFactory zipFactory, Object revisionLock, File rootDir, File dir) { m_logger = logger; m_configMap = configMap; m_zipFactory = zipFactory; m_revisionLock = revisionLock; m_rootDir = rootDir; m_dir = dir; + String canonicalPath = null; + try { + canonicalPath = BundleCache.getSecureAction().getCanonicalPath(m_dir); + } catch (IOException e) { + throw new UncheckedIOException(e); + } + if (!canonicalPath.endsWith(File.separator)) { + canonicalPath = canonicalPath + "/"; Review Comment: OK, thanks! I haven't tried a narrow re-prod yet - I had just naively merged a dependabot PR and was surprised to see tests failing on Windows that were passing on Linux so started digging around the differences/changlog. Will follow that JIRA, so can let me know if you need more detail/narrow reprod. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org