cziegeler commented on code in PR #170:
URL: https://github.com/apache/felix-dev/pull/170#discussion_r939535509
##########
configurator/src/main/java/org/apache/felix/configurator/impl/model/State.java:
##########
@@ -39,9 +39,8 @@ public class State extends AbstractState implements
Serializable {
public static final String FILE_NAME = "state.ser";
- private Map<Long, Long> bundlesLastModified = new HashMap<>();
-
- private Map<Long, Long> bundlesConfigAdminBundleId = new HashMap<>();
+ private Map<Long, Long> bundlesLastModified = new ConcurrentHashMap<>();
Review Comment:
Tom is right, you need to create the right type on deseralization.
But, it might also be that the synchronization is on the wrong level and
instead of making the properties of this class thread safe take care of syncing
on a higher level. I think, that was the intention, but I can't really remember
the details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
