fipro78 commented on code in PR #70:
URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145929755
##########
atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java:
##########
@@ -121,7 +121,7 @@ public List<String> arguments()
.map(Path::toAbsolutePath)//
.sorted(NativeImageArgumentsImpl::byAbsolutePath)//
.map(Path::toString)//
- .collect(Collectors.joining(":"));
+ .collect(Collectors.joining(NativeImageCliUtil.isWindows() ? ";" :
":"));
Review Comment:
Just to provide more details in case someone else stumbles across this in
the future:
`java --help` on Windows returns
```
--class-path <class search path of directories and zip/jar files>
A ; separated list of directories, JAR archives,
and ZIP archives to search for class files.
--module-path <module path>...
A ; separated list of directories, each directory
is a directory of modules.
```
`java --help` on a Unix system returns:
```
--class-path <class search path of directories and zip/jar files>
A : separated list of directories, JAR archives,
and ZIP archives to search for class files.
--module-path <module path>...
A : separated list of directories, each directory
is a directory of modules.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
