[
https://issues.apache.org/jira/browse/FELIX-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748496#comment-17748496
]
Carsten Ziegeler commented on FELIX-6565:
-----------------------------------------
[~amitmondal] Thanks for the update. Minor issue, a servlet can't be registered
with a context path or name. It can only be registered with the "select"
property (see
https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.http.whiteboard.html#service.http.whiteboard.common.properties)
So, from a configuration point, only the context name should be configurable.
If it is set, the select property should be set on the servlet registration.
It would be great if you could adjust the PR, otherwise I can do it after I
applied the current state.
> Make OSGi HTTP Package dependency optional in HealthCheck core bundle
> ---------------------------------------------------------------------
>
> Key: FELIX-6565
> URL: https://issues.apache.org/jira/browse/FELIX-6565
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
> Reporter: Amit Mondal
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: healthcheck.core 2.0.16
>
>
> Currently, the Felix HealthCheck core bundle mandatorily imports
> org.osgi.service.http package which is used by
> {_}*HealthCheckExecutorServlet*{_}. In our current system, we don't use HTTP
> at all, hence, neither _*javax.servlet*_ nor _*org.osgi.service.http*_ is
> available in the runtime. Hence, the health checks don't work as it
> mandatorily requires _*org.osgi.service.http*_ package dependency. Since,
> _*HealthCheckExecutorServlet*_ is not a core component for the health checks,
> we can consider the following options:
> # Provide a separate bundle with HTTP dependency (invasive approach)
> # Make _*org.osgi.service.http*_ an optional package for HealthCheck core
> and conditionally enable _*HealthCheckExecutorServlet*_ component if
> _*org.osgi.service.http*_ is wired to the HealthCheck core bundle (similar
> approach we did for Quartz to check the availability of Quartz in runtime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
