jsedding commented on code in PR #250:
URL: https://github.com/apache/felix-dev/pull/250#discussion_r1412885508
##########
cm.json/src/test/java/org/apache/felix/cm/json/io/impl/JsonSupportTest.java:
##########
@@ -307,4 +307,19 @@ public void testEscapedQuotes() throws IOException {
+ "}\n", parse(input));
}
+ @Test
+ public void testSlashAtEndOfRead() throws Exception {
+ String input = "This is a test string // Next string \n"
+ + "next line" ;
+ Reader reader = JsonSupport.createCommentRemovingReader(new
StringReader(input));
+
+ char[] buffer = new char[22];
Review Comment:
Nit: Instead of the magic number 22, how about using `input.indexOf('/')`?
Or something equivalent, if I misunderstood the intent. IMHO that would make it
clearer what you're testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
