enapps-enorman commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2073074091
@paulrutter Thanks for reviewing and providing feedback. I haven't tried this with jetty12, but the documentation looks similar with 2 additional implementations (Jakarta EE 8 and Jakarta EE 10). After reviewing the jetty12 documentation, I will rename the "org.apache.felix.jakarta.websocket.enable" option to "org.apache.felix.jakarta.ee9.websocket.enable" to avoid conflicts if we decide to go with this solution and expand it to support the other two options for jetty12. Regarding the jetty bundles that are required, below is what I believe is the minimum set of additional bundles to satisfy the dependencies: For the jetty specific websocket implementation --- - org.eclipse.jetty:jetty-webapp - org.eclipse.jetty.websocket:websocket-core-common - org.eclipse.jetty.websocket:websocket-core-server - org.eclipse.jetty.websocket:websocket-jetty-api - org.eclipse.jetty.websocket:websocket-jetty-common - org.eclipse.jetty.websocket:websocket-jetty-server - org.eclipse.jetty.websocket:websocket-servlet - org.eclipse.jetty:jetty-xml For the jakarta EE9 specific websocket implementation --- - jakarta.websocket:jakarta.websocket-api - org.eclipse.jetty:jetty-alpn-client - org.eclipse.jetty:jetty-client - org.eclipse.jetty:jetty-webapp - org.eclipse.jetty.websocket:websocket-core-client - org.eclipse.jetty.websocket:websocket-core-common - org.eclipse.jetty.websocket:websocket-core-server - org.eclipse.jetty.websocket:websocket-jakarta-client - org.eclipse.jetty.websocket:websocket-jakarta-common - org.eclipse.jetty.websocket:websocket-jakarta-server - org.eclipse.jetty.websocket:websocket-servlet - org.eclipse.jetty:jetty-xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
