tjwatson commented on code in PR #76:
URL: https://github.com/apache/felix-atomos/pull/76#discussion_r1633357634
##########
atomos/src/main/java/org/apache/felix/atomos/impl/base/AtomosBase.java:
##########
@@ -1663,9 +1663,8 @@ void addPackages(Bundle b)
try
{
content.getEntries().forEach((s) -> {
- if (s.length() > 1 && s.endsWith("/") &&
s.indexOf('-') < 0)
- {
- String pkg = s.substring(0, s.length() -
1).replace('/', '.');
+ if (s.endsWith(".class")) {
Review Comment:
Can we change this to be `if (!s.endswith("/") && s.contains("/")) {`
In other words all paths that are not directories (don't end with "/") and
are not part of the default package (paths with no "/" at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
