kwin commented on code in PR #345: URL: https://github.com/apache/felix-dev/pull/345#discussion_r1844203094
########## cm.json/src/main/java/org/apache/felix/cm/json/io/package-info.java: ########## @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -@Version("1.0.0") +@Version("1.1.0") Review Comment: This is a potentially backward incompatible semantical change (affecting consumers). Just a change which is not detected by baselining because the method signature did not change. Therefore adjusting the minor version is IMHO the right thing to do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org