laeubi commented on PR #322:
URL: https://github.com/apache/felix-dev/pull/322#issuecomment-2483362362

   > <Embed-Dependency> is trivially simple in bnd-maven-plugin
   
   one would think so, but if you
   
   1. don't know it by name
   2. don't check in the jar into your code repository
   
   it instantly become incredibly hard. As you mentioned 
[here](https://stackoverflow.com/questions/58718160/how-to-embed-a-maven-dependency-with-bnd-maven-plugin)
   
   > Sadly, there is no way to specify transitive inclusion natively in bnd
   
   Also  `includeresource` can not filter for scopes (as far as I know) and you 
have to know the name of the artifact as described 
[here](https://github.com/bndtools/bnd/issues/3704).
   
   So yes that's all doable but far from convenient to the not so experienced 
users.
   
   Also please keep in mind this important portion of my answer:
   
   > but that's really cumbersome if **more than one jar is involved**
   
   so all these incredible easy example always ever seem to cover **exactly one 
jar** where it in fact becomes quite easy.
   
   So to convince people that `bnd-maven-plugin` is a full replacement, I think 
the best would be to add docs that cover [the 
examples](https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_embedding_dependencies)
 mentioned here:
   
   ```
   <!-- embed all compile and runtime scope dependencies -->
   <Embed-Dependency>*;scope=compile|runtime</Embed-Dependency>
   
   <!-- embed any dependencies with artifactId junit and scope runtime -->
   <Embed-Dependency>junit;scope=runtime</Embed-Dependency>
   
   <!-- inline all non-pom dependencies, except those with scope runtime -->
   <Embed-Dependency>*;scope=!runtime;type=!pom;inline=true</Embed-Dependency>
   
   <!-- embed all compile and runtime scope dependencies, except those with 
artifactIds in the given list -->
   
<Embed-Dependency>*;scope=compile|runtime;inline=false;artifactId=!cli|lang|runtime|tidy|jsch</Embed-Dependency>
   
   <!-- inline contents of selected folders from all dependencies -->
   <Embed-Dependency>*;inline=images/**|icons/**</Embed-Dependency>
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to