cziegeler commented on code in PR #364:
URL: https://github.com/apache/felix-dev/pull/364#discussion_r1924208318
##########
http/base/src/main/java/org/apache/felix/http/base/internal/handler/ServletHandler.java:
##########
@@ -42,6 +44,9 @@ public abstract class ServletHandler implements
Comparable<ServletHandler>
private static final String JAVA_SERVLET_TEMP_DIR_PROP =
"jakarta.servlet.content.tempdir";
Review Comment:
How about moving the extra handling into a subclass and keep ServletHandler
generic - and then make a decision when a new ServletHandler class is created
whether this or the subclass should be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
