gnodet commented on code in PR #390: URL: https://github.com/apache/felix-dev/pull/390#discussion_r1983703704
########## gogo/jline/src/main/java/org/apache/felix/gogo/jline/Builtin.java: ########## @@ -683,7 +684,7 @@ public List<Candidate> __files(CommandSession session) { List<Candidate> candidates = new ArrayList<>(); new FilesCompleter(session.currentDir()) { @Override - protected String getDisplay(Terminal terminal, Path p) { + protected String getDisplay(Terminal terminal, Path p, StyleResolver resolver, String separator) { Review Comment: The indentation looks weird. ########## gogo/jline/src/main/java/org/apache/felix/gogo/jline/Builtin.java: ########## @@ -696,7 +697,7 @@ public List<Candidate> __directories(CommandSession session) { List<Candidate> candidates = new ArrayList<>(); new DirectoriesCompleter(session.currentDir()) { @Override - protected String getDisplay(Terminal terminal, Path p) { + protected String getDisplay(Terminal terminal, Path p, StyleResolver resolver, String separator) { Review Comment: The indentation looks weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org