[
https://issues.apache.org/jira/browse/FELIX-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949214#comment-17949214
]
Richard S. Hall commented on FELIX-6773:
----------------------------------------
That probably makes sense, but you'll probably still need to check if it is a
fragment, like in the other path. Maybe it would make more sense to move the
fragment check to the loop processing the startList so the check only has to be
done in one place.
> ResolverImpl downloading bundles it doesn't need to
> ---------------------------------------------------
>
> Key: FELIX-6773
> URL: https://issues.apache.org/jira/browse/FELIX-6773
> Project: Felix
> Issue Type: Bug
> Components: Bundle Repository (OBR)
> Affects Versions: bundlerepository-2.0.10
> Reporter: James Roome
> Priority: Minor
>
> LazyLocalResourceImpl doesn't implement the equals method. Due to this when
> it is compared to another Resource with the same symbolic name and version is
> returns false.
> Impacts: ResolverImpl, which will do an unneeded download and update, due to
> this check failing:
> {code:java}
> if (!localResource.equals(deployResource)){code}
> Fix: Implement equals in LazyLocalResourceImpl:
> {code:java}
> public boolean equals(Object o) { return getResource().equals(o); }{code}
> I'll submit the above fix as a pull request on the apache-dev github repo.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
