glimmerveen commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2873777981
> I need SCR on Java 8 for the now. > > Do we have performance metrics that show an improvement here? I don't have a specific performance metric I can refer to, but I did notice that with a tiny `ds.service.changecount.timeout` (`10`, or `0` even), and a lot of updates to the changecount, that the timer (and by extension the underlying thread) gets re-created a lot. Another benefit is that the code becomes a bit simpler, as there is no need to cancel midway (nor the synchronisation that is currently present to ensure this happens consistently). > > Can someone explain what `ds.service.changecount.timeout` controls? If I read the code right, it provides a delay for setting the `service.changecount`. Is that to avoid blasting service modified events for the `ServiceComponentRuntime` registration? So we always wait some amount of time before setting the service property? I presume this is the reason, but I am not familiar with the exact reason(s) for this design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
