tjwatson commented on code in PR #438:
URL: https://github.com/apache/felix-dev/pull/438#discussion_r2279123909
##########
scr/src/main/java/org/apache/felix/scr/impl/Activator.java:
##########
@@ -225,9 +225,11 @@ protected void doStart() throws Exception
super.doStart();
- m_componentCommands = new ComponentCommands(m_context,
m_globalContext, runtime, m_configuration);
- m_componentCommands.register();
-
m_componentCommands.updateProvideScrInfoService(m_configuration.infoAsService());
+ if(m_configuration.getCommandsEnabled()) {
+ m_componentCommands = new ComponentCommands(m_context,
m_globalContext, runtime, m_configuration);
+ m_componentCommands.register();
+
m_componentCommands.updateProvideScrInfoService(m_configuration.infoAsService());
Review Comment:
I don't have a strong opinion on this, but want to make sure you intended to
disable the gogo `scr:` commands AND disable registering the
`org.apache.felix.scr.info.ScrInfo` service here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
