laeubi commented on PR #433:
URL: https://github.com/apache/felix-dev/pull/433#issuecomment-3356801123

   > I have a distaste for MRJ. If we create a `SecurityManagerFacade` then I 
would prefer that to just load the right class depending on the Java version 
behind that instead of being hidden behind class loader MRJ stuff.
   
   But this will only work if the API is not gone (or non existent) if you not 
choose reflection ... what is a nightmare on its own of course.
   
   > But the first blocker from me was source code debugging and what the 
source JAR looks like for the release. It was a nightmare to debug. Maybe all 
that is fixed by now. 
   
   As said MR support in JDT is quite new and there is obviously a lot to 
improve, but if anything is missing it could be linked here:
   - https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4275
   
   so I can only invite everyone to participate there :-)
   
   >  But it seemed far more simple to just choose the class to load myself in 
code.
   
   While this might work in this case (see above) this is simply not manageable 
for any more complex API as it would require you to use reflection all the 
time, that has no compile time checking, it has no real debugging support or 
anything so not really something I would call "more simple".
   
   > and what the source JAR looks like for the release. 
   
   The source jar?!? Do you mean the final build jar or the source code in the 
project?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to