[
https://issues.apache.org/jira/browse/FELIX-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053366#comment-18053366
]
Georg Henzler commented on FELIX-6815:
--------------------------------------
yes the ServiceListener is a better approach, I agree.
But the other question remains: Does http://localhost:8080 really make sense as
a default or would it make more sense to let the HC return a result that
indicates that while no HttpService is active, relative URLs starting with "/"
are skipped (could be WARN or TEMPORARILY_UNAVAILABLE, but I would not actually
fire a request for that case).
> HttpRequestsCheck may initialise with the wrong defaultBaseUrl during
> activation
> --------------------------------------------------------------------------------
>
> Key: FELIX-6815
> URL: https://issues.apache.org/jira/browse/FELIX-6815
> Project: Felix
> Issue Type: Improvement
> Components: Health Checks
> Affects Versions: healthcheck.generalchecks 3.0.8
> Reporter: Georg Henzler
> Assignee: Georg Henzler
> Priority: Major
>
> FELIX-6635 introduced the default value of http://localhost:8080 which is
> sometimes set incorrectly during startup due to a race condition if the http
> service isn't there yet while HttpRequestsCheck is activated, see
> https://github.com/apache/felix-dev/commit/866c7e7bb0f50719916b6c42a3c0be65ac96a1b5
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
