francescomari commented on code in PR #482:
URL: https://github.com/apache/felix-dev/pull/482#discussion_r2923437230
##########
http/jetty/src/main/java/org/apache/felix/http/jetty/internal/MBeanServerTracker.java:
##########
@@ -59,6 +59,7 @@ public void removedService(ServiceReference<MBeanServer>
reference, MBeanContain
{
if ( service != null )
{
+ service.destroy();
Review Comment:
It doesn't look like. That method clears some data structures and
deregisters every registered MBeans. The only code that can throw is called
indirectly in `org.eclipse.jetty.jmx.MBeanContainer#unregister`, but that
method already has proper exception handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
