stbischof commented on code in PR #486:
URL: https://github.com/apache/felix-dev/pull/486#discussion_r2927346583
##########
scr/src/main/java/org/apache/felix/scr/impl/inject/methods/BaseMethod.java:
##########
@@ -166,7 +166,7 @@ private MethodInfo<T> findMethod(final ComponentLogger
logger) throws Invocation
// This is 'Debug' however, as the class information, where the
search
// was conducted, is quite important for the client's own debugging
logger.log(Level.DEBUG,
- "Locating method " + getMethodName() + " within class " +
theClass.getName(), null );
+ "Locating method {0} within class {1}", null,
getMethodName(), theClass.getName());
Review Comment:
is that with null as parem not one param to much?
##########
scr/src/main/java/org/apache/felix/scr/impl/inject/methods/BaseMethod.java:
##########
@@ -177,7 +177,7 @@ private MethodInfo<T> findMethod(final ComponentLogger
logger) throws Invocation
// Trace as this is going through the whole hierachy and will
log for non-existing methods
// a lot of lines for e.g. the class Object not containing an
activate method
logger.log(Level.TRACE,
- "Locating method " + getMethodName() + " in class " +
theClass.getName(), null );
+ "Locating method {0} in class {1}", null,
getMethodName(), theClass.getName());
Review Comment:
is that with null as parem not one param to much?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
