paulrutter commented on PR #552:
URL: https://github.com/apache/felix-dev/pull/552#issuecomment-5464748799
## CI is red on purpose — Apache RAT rejects the vendored sources
Now that stacked PRs get CI (the `pull_request` trigger only accepted
`master` as a base, so this PR was getting no build at all until that was fixed
on the base branch), the build runs — and fails on all four JDKs in exactly the
way that matters:
```
[INFO] Rat check: Summary over all files. Unapproved: 12, unknown: 12,
generated: 0, approved: 243 licenses.
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check
(default)
on project org.apache.felix.framework: Too many files with
unapproved license: 12
```
All 12 flagged files are the vendored plurl sources — the 11 `.java` files
plus the `README.md`. Nothing else in the framework is flagged.
**This is the licensing question answering itself.** `apache-rat-plugin` is
the ASF's own compliance gate, and it will not accept `SPDX-License-Identifier:
EPL-2.0` headers in an Apache source tree. It is enforcing the [Category
B](https://www.apache.org/legal/resolved.html#category-b) rule automatically.
Equinox could vendor these files because Eclipse projects are EPL-2.0 natively;
Felix cannot.
The failure is being left in place deliberately. It could be silenced with a
RAT exclusion for `plurl/**`, but that would suppress a genuine compliance
violation rather than resolve it, and would leave a green tick implying the
licensing was settled when it is not. Red is the accurate state: **this branch
cannot merge as it stands.**
So the technical side is done and the remaining blocker is purely licensing:
- the framework compiles and its tests are unchanged with plurl vendored and
`PlurlURLHandlers` wired in;
- the only thing standing in the way is the header discrepancy — plurl's
`LICENSE` and `pom.xml` say Apache-2.0, while every source file says EPL-2.0
with `Copyright (c) 2025 IBM Corporation`.
@tjwatson — if the EPL headers are carried over from the original Equinox
code rather than intended, correcting them upstream to match plurl's own
Apache-2.0 LICENSE and pom would turn this red build green and unblock the
approach for Felix and anyone else wanting to adopt the library. If they are
intentionally EPL-2.0, then Felix needs one of the alternatives listed in the
PR description instead.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
