paulrutter commented on PR #554: URL: https://github.com/apache/felix-dev/pull/554#issuecomment-5465126908
Added a CI fix, because the green TCK run on the previous commit **did not actually validate anything in this PR**. The workflow ran `--file framework/pom.xml clean verify`, which does not install. The TCK is a separate Maven invocation, so it resolves `org.apache.felix.framework` from the repository rather than from the build that just ran — and `7.1.0-SNAPSHOT` exists in `apache.snapshots`. Resolution therefore succeeded against the *published* snapshot, and the TCK never exercised the code under test. That matters most for this PR specifically: the `FilterImpl` defects fixed here are exactly what the TCK reports, so a green TCK proved nothing while the framework was being resolved from elsewhere. This surfaced on #433, where renaming the framework to `8.0.0-SNAPSHOT` removed the fallback and turned the silent substitution into a loud error: ``` Could not find artifact org.apache.felix:org.apache.felix.framework:jar:8.0.0-SNAPSHOT in apache.snapshots ``` The step now runs `clean install`, so the TCK tests the framework this build produces. The next run here is the first one whose TCK result actually says something about this change. For what it is worth, the fix was verified locally against the real thing: the TCK went from 33 errors, to 14 after repairing the `Map` constructor, to `BUILD SUCCESS` with 0 errors after repairing the `ServiceReference` constructor. The unit tests added here were also checked in both directions — they fail with `UnsupportedOperationException` against current master and pass with the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
