paulrutter commented on PR #564: URL: https://github.com/apache/felix-dev/pull/564#issuecomment-6015958222
Thanks, the changes address my comments. Making `caps`/`reqs` private closes the stale-hash gap for subclasses, and I agree there's no need to wrap the returned lists, since the `Resource` javadoc already says they're unmodifiable. `testHashCodeZero` now covers the zero-hash path, and the counting requirement makes the caching explicit. One small thing to check: if any downstream subclass (e.g. in Karaf) uses the formerly protected `caps`/`reqs` fields, it will stop compiling, so it may be worth a quick look there. Otherwise LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
