Jefiya-MJ commented on PR #544: URL: https://github.com/apache/felix-dev/pull/544#issuecomment-6857242451
Hi @paulrutter Thanks for the review! I have addressed all the feedback and rebased onto latest master: READ_ONLY leak fixed: Moved the ownership check before clearReadOnlyIfWritable() in setConfig() and added a test to ensure READ_ONLY attributes are preserved. Normalized file comparison: Switched from URI string equality to normalized File paths in setConfig() and deleteConfig() to handle ./.. segments and equivalent path representations. Logging & Javadoc: Added WARNING logs with PID and owner details when skipping updates/deletions, and updated deleteConfig() Javadoc. CI & DirectoryWatcherTest: Resolved merge conflicts, wired fileinstall into GitHub Actions CI (clean test), and fixed DirectoryWatcherTest.testInvalidTempDir with a deterministic fixture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
