FelixMarxIBM commented on PR #233: URL: https://github.com/apache/felix-dev/pull/233#issuecomment-6918058612
Thanks for all your concerns @paulrutter . I'm not sure we do need the `Files.move(..., ATOMIC_MOVE, REPLACE_EXISTING)` approach. I would only consider this if there is a known safe way to create such temp files that do not conflict with any actual config file. If that is not possible, I'd prefer the current approach. I've worked on the reaming requests and also added a test for the deadlock situation that is only possible in a non-compliant setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
