Hi PJ, Thank you very much for the thorough review and your mentorship. Your guidance on the licensing and release process is invaluable to us.
I accept your suggestions and will make the following corrections for the next release candidate: 1. Binary Distribution: I agree that as a library, a binary distribution is not strictly necessary. We will remove the bin.tar.gz artifact to simplify licensing management and focus on the source release. 2. Shadowed Classes: We will review the fastexcel-support module and remove the shadowed classes (asm/cglib) to ensure compliance with ASF licensing policies. 3. POM Metadata: I will update the pom.xml files to include the standard "Apache Fesod (incubating)" name and the required Incubation Disclaimer in the project description. 4. KEYS File: I will move the KEYS file from the dist/dev repository to the dist/release repository and use the correct downloads.apache.org link in future emails. 5. Process: Apologies for missing the discussion step. I will ensure to start a [DISCUSS] thread on the dev list before initiating the vote for RC2. Regarding the vote timeline: Although this vote has already received a -1, I plan to keep this thread open for another 24 hours to see if other mentors or community members spot any additional issues. This will help us address everything in one go for RC2. After that, I will formally cancel this vote. Best, Shuxin Pan On Mon, Dec 29, 2025 at 3:41 AM PJ Fanning <[email protected]> wrote: > > -1 binding > The LICENSE and NOTICE file in the > apache-fesod-2.0.0-incubating-bin.tar.gz are incorrect. > They do not relate to the contents of that file. They are related to > the src tar.gz but the LICENSE and NOTICE file in the binary > convenience archives need to describe what is in that tar.gz - eg the > license details of all the jars included in it. So you have a licenses > dir but the LICENSE file should not mention mvnw if it isn't in the > tar.gz. > The NOTICE files for the Apache licensed jars are missing from the > licenses dir. The LICENSE files in the license dir are generic license > files and not the specific ones for the supposedly related jars. I > know that the real POI license files mention some third party code > that is used in POI. > > What is fastexcel-support-1.3.0.jar? It appears to have asm and cglib > classes. Are these copies of the classes from the asm and cglib > projects and if so the licenses/LICENSE-fastexcel-support.txt file > appears invalid to me. > > Fesod is a set of libs, at heart. Do you we really even need a bin > tar.gz? What is its purpose? > > Can't we just ship the jars and not have a bin tar.gz? > > Also the fesod jars that are in > https://repository.apache.org/content/repositories have POMs that do > not include the disclaimer text in their project descriptions. > They do not include 'Apache Fesod (incubating)' as the developer. Most > mentions of Fesod omit the Apache prefix. Can this be corrected? > See these requirements: > https://incubator.apache.org/guides/distribution.html#maven_distribution > > Example pom: > https://repository.apache.org/content/repositories/orgapachefesod-1011/org/apache/fesod/fesod-common/2.0.0-incubating/fesod-common-2.0.0-incubating.pom > > On Sun, 28 Dec 2025 at 19:53, PJ Fanning <[email protected]> wrote: > > > > Also, it an ASF requirement to discuss releases on your dev mailing list > > before starting a vote. > > > > > > On 2025/12/28 18:51:28 PJ Fanning wrote: > > > The KEYS file is in the wrong place. > > > It should be in > > > https://dist.apache.org/repos/dist/release/incubator/fesod/KEYS > > > > > > It will then be automatically synched to > > > https://downloads.apache.org/incubator/fesod/KEYS > > > > > > You should use the latter in the VOTE emails. > > > Can you delete the file in dev/incubator/fesod/KEYS ? > > > > > > Can this be fixed? It doesn't mean restarting the release. > > > > > > Is there a release guide to track the build requirements and if so can > > > it be fixed? > > > > > > On Sun, 28 Dec 2025 at 15:36, Shuxin Pan <[email protected]> wrote: > > > > > > > > Hi Fesod Community, > > > > > > > > This is a call for vote to release Apache Fesod(incubating) > > > > 2.0.0-incubating. > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/fesod/2.0.0-incubating-rc1/ > > > > > > > > The staging repo: > > > > https://repository.apache.org/content/repositories/orgapachefesod-1011/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/fesod/releases/tag/2.0.0-incubating-rc1 > > > > > > > > Hash for the release tag: > > > > 6d5139a93521de98cf67eeff6d798ddecd4ab82d > > > > > > > > Release Notes: > > > > https://github.com/apache/fesod/releases/tag/2.0.0-incubating-rc1 > > > > > > > > The artifacts have been signed with Key [ 72D5936C ], corresponding > > > > to > > > > [ [email protected] ] > > > > which can be found in the keys file: > > > > https://dist.apache.org/repos/dist/dev/incubator/fesod/KEYS > > > > > > > > Build Environment: JDK 8+, Apache Maven 3.6.0+. > > > > ./mvnw clean package -DskipTests > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > [ ] Checksums and signatures. > > > > [ ] LICENSE/NOTICE files exist > > > > [ ] No unexpected binary files > > > > [ ] All source files have ASF headers > > > > [ ] Can compile from source > > > > > > > > To learn more about Apache Fesod , please see https://fesod.apache.org/ > > > > > > > > Best, > > > > Shuxin Pan > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
