Hi all,
Here's a summary of the changes we discussed making to Adhyan's code. In
parallel, Nazeer will be reviewing Courage's PR around the
publisher/subscriber model.
Summary of Changes to Adhyan’s Implementation:
-
Usage of Notification Subsystem should be option and turned on or off by
configuration
-
Don’t want to force every user to have ActiveMQ installed on their
server
-
Need configuration to make it optional to use notifications
-
All notifications generated should be asynchronous
-
Implement a debounce such that no matter how many requests come from
user, will only look up in DB, once every 60 seconds
-
Addresses Nazeer’s concern of making DB calls whether not user has
new or not with each hit to the server.
-
Add to installation document details on how to install and configur
ActiveMQ as most implementers won’t understand this
-
Pranjal: just using out of box functionalities so all need to do is
install and specify port
-
but will put this in the document.
-
Once ActiveMQ is up and running, at time of broadcasting, simply
need to communicate with ActiveMQ and listeners connect to it.
On Thu, Aug 24, 2017 at 11:56 PM, Ed Cable <edca...@mifos.org> wrote:
> Hi Nazeer,
>
> I know that you're going through code review of Adhyan's work on
> notifications framework from last year's GSOC. Courage has built on top of
> Adhyan's work and has a PR that's ready for review as well. I was hoping we
> could get on a quick call with Pranjal to discuss outstanding issues and
> merging of Courage's work.
>
> Would 1300GMT work on Friday?
>
> Thanks,
>
> Ed
>
>
>
--
*Ed Cable*
President/CEO, Mifos Initiative
edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
