Ed, There was only one single commit missing for which Courage has created a PR (https://github.com/openMF/community-app/pull/2438), Nazeer is reviewing the backend (https://github.com/apache/fineract/pull/405), as soon as he is done, it will be merged.
Regards Mohit On 23 September 2017 at 02:37, Ed Cable <[email protected]> wrote: > Mohit, > > What did we need to do to make sure there are no missing commits from > Adhyan's work? > > Where do we stand with the merge of courage's work? > > Ed > > On Tue, Sep 12, 2017 at 10:41 AM, Adhyan Srivastava <[email protected]> > wrote: > >> No worries, thank you very much for the clarification. >> >> On Tue, 12 Sep 2017 at 22:55 Mohit Bajoria <[email protected]> wrote: >> >>> Hello Adhyan, >>> >>> We had the very difficult merge situation while merging Duplex GSOC >>> project, there were lots of regression issues and new issues occured, We >>> had to be in sync with current develop so we do not lose the changes, we >>> did some of the changes manually, In all of the process of manually >>> changing the commit, this would have occured. I am very sorry about that. >>> >>> Regards >>> Mohit >>> >>> On 12 September 2017 at 22:42, Ed Cable <[email protected]> wrote: >>> >>>> Could you please look into why some of Adhyan's code is not the new web >>>> app code? >>>> >>>> Thanks, >>>> >>>> Ed >>>> >>>> On Tue, Sep 12, 2017 at 10:10 AM, Adhyan Srivastava < >>>> [email protected]> wrote: >>>> >>>>> Hi Everyone, >>>>> >>>>> I don't know how but some part of my front end code is not there in >>>>> the new community app code. I had my front end code merged with Duplex's >>>>> code during GSOC-2016. The PR which courage has sent looks good to me and >>>>> notifications will be fetched in the app after it is merged. >>>>> >>>>> Thanks! >>>>> >>>>> On Tue, 12 Sep 2017 at 21:44 Mohit Bajoria <[email protected]> >>>>> wrote: >>>>> >>>>>> Hello Courage, >>>>>> >>>>>> I had a quick look at the PR, it looks good to me, @Nazeer Could you >>>>>> please >>>>>> recheck and merge? >>>>>> >>>>>> Is the Notification Module has been merged in the backend ? >>>>>> >>>>>> Regards >>>>>> Mohit >>>>>> >>>>>> On 12 September 2017 at 02:49, Ed Cable <[email protected]> wrote: >>>>>> >>>>>> > Forwarding this to the dev lists to stay on-thread. >>>>>> > >>>>>> > Ed >>>>>> > ---------- Forwarded message ---------- >>>>>> > From: courage angeh <[email protected]> >>>>>> > Date: Mon, Sep 11, 2017 at 2:15 PM >>>>>> > Subject: Re: Notifications Framework working in conjunction with >>>>>> Offline >>>>>> > Mode in Chrome >>>>>> > To: Ed Cable <[email protected]> >>>>>> > >>>>>> > >>>>>> > Hi guys, >>>>>> > >>>>>> > The front-end still needs some configurations to connect it to the >>>>>> > back-end. I added that in a pull request (plus some design update on >>>>>> > identify new messages) >>>>>> > https://github.com/openMF/community-app/pull/2438 >>>>>> > >>>>>> > Could Mohit review this please? >>>>>> > >>>>>> > Thanks, >>>>>> > Courage >>>>>> > >>>>>> > On Mon, Sep 11, 2017 at 6:03 PM, Ed Cable <[email protected]> >>>>>> wrote: >>>>>> > >>>>>> >> Pranjal, Courage, and Adhyan, >>>>>> >> >>>>>> >> Could we set up a call with Mohit to discuss the issues he's >>>>>> facing in >>>>>> >> trying to get the notifications framework to work with the >>>>>> enhancements he >>>>>> >> made to enable offline access in Chrome. He'd like to be able to >>>>>> have >>>>>> >> notifications that are generated while offline get synced when >>>>>> going online. >>>>>> >> >>>>>> >> I'll let him discuss specifics but details of his project can be >>>>>> found at >>>>>> >> https://gist.github.com/mbj36/105c47ccc10890cc4c71582ad63cff23 >>>>>> >> >>>>>> >> Thanks, >>>>>> >> >>>>>> >> Ed >>>>>> >> >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > -- >>>>>> > *Ed Cable* >>>>>> > President/CEO, Mifos Initiative >>>>>> > [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >>>>>> <(484)%20477-8649> >>>>>> > >>>>>> > *Collectively Creating a World of 3 Billion Maries | * >>>>>> http://mifos.org >>>>>> > <http://facebook.com/mifos> <http://www.twitter.com/mifos> >>>>>> > >>>>>> > >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> *Regards* >>>>>> *Mohit Kumar Bajoria* >>>>>> *http://mohitbajoria.com <http://mohitbajoria.com>* >>>>>> >>>>> >>>> >>>> >>>> -- >>>> *Ed Cable* >>>> President/CEO, Mifos Initiative >>>> [email protected] | Skype: edcable | Mobile: +1.484.477.8649 >>>> <(484)%20477-8649> >>>> >>>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org >>>> <http://facebook.com/mifos> <http://www.twitter.com/mifos> >>>> >>>> >>> >>> >>> -- >>> >>> *Regards* >>> *Mohit Kumar Bajoria* >>> *http://mohitbajoria.com <http://mohitbajoria.com>* >>> >> > > > -- > *Ed Cable* > President/CEO, Mifos Initiative > [email protected] | Skype: edcable | Mobile: +1.484.477.8649 > > *Collectively Creating a World of 3 Billion Maries | *http://mifos.org > <http://facebook.com/mifos> <http://www.twitter.com/mifos> > > -- *Regards* *Mohit Kumar Bajoria* *http://mohitbajoria.com <http://mohitbajoria.com>*
