The approach of sleeping for a fixed time does not work well in general as 
Integration test cases must pass on any environment. Depending on random sleep 
values would mean that there is always a probability that the test can fail if 
the system is slow / has other CPU intensive processes running etc.

Ideally , you would handle such scenarios more gracefully . Have the test check 
if the file you are referring to is created , if not sleep for an interval and 
check again etc. 

Please make this change and send out a pull request

Regards,
Vishwas

> On Feb 14, 2018, at 9:39 AM, Kumaranath Fernando 
> <kumaranathferna...@gmail.com> wrote:
> 
> I've tested the develop branch and it's most likely because the result excel 
> file takes a bit of time to be created, after the file is created I'm trying 
> to read a value of a column.
> Since the file is not created by the time FileInputStream reads the file, you 
> get a FileNotException.
> 
> You could fix this issue by increasing the number of milliseconds 10000 on 
> Thread.sleep() line in the respective tests.Ping me if this resolves the 
> issue and I'll send PR.
> 
> Vishwas/Nazeer awaiting your confirmation!.
> 
> Regards,
> Kumaranath Fernando
> 
> 
>> On Wed, Feb 14, 2018 at 10:59 AM, vishwas <vish...@confluxtechnologies.com> 
>> wrote:
>> Hi Kumaranath,
>> 
>> You should be able to reproduce this issue if you fetch the latest fineract 
>> code in a seperate workspace.
>> 
>> If the remember correctly, the crux of the issue seemed be be that files you 
>> were referring to in the test cases , i.e 
>> fineract-provider/src/integrationtest/resources/bulkimport/importhandler/officer
>>  are not present and all these tests cases throw a file not found exception.
>> 
>> Regards,
>> Vishwas
>> 
>> 
>> 
>> > On Feb 13, 2018, at 6:43 PM, Kumaranath Fernando 
>> > <kumaranathferna...@gmail.com> wrote:
>> >
>> > Hi Nazeer!
>> >
>> > Could you please send in the stack traces for investigation.
>> >
>> > Regards,
>> > Kumaranath Fernando
>> >
>> > On Wed, Feb 14, 2018 at 12:43 AM, Ed Cable <edca...@mifos.org 
>> > <mailto:edca...@mifos.org>> wrote:
>> >
>> >> Please keep the community posted and try to address as quickly as you can
>> >> we have one other issue we're fixing and then once these integration tests
>> >> pass, we can call for a vote to ship the release.
>> >>
>> >> Ed
>> >>
>> >> On Tue, Feb 13, 2018 at 6:02 AM, Kumaranath Fernando <
>> >> kumaranathferna...@gmail.com> wrote:
>> >>
>> >>> Hello Ed!
>> >>>
>> >>> Sure. I'll take a look at it!
>> >>>
>> >>> Regards,
>> >>> Kumaranath Fernando
>> >>>
>> >>> On Tue, Feb 13, 2018 at 11:40 AM, Ed Cable <edca...@mifos.org> wrote:
>> >>>
>> >>>> Kumaranath,
>> >>>>
>> >>>> Could you please look into these failing integration tests? It's one of
>> >>>> the last items we need to address before we can release.
>> >>>>
>> >>>> Thanks,
>> >>>>
>> >>>> Ed
>> >>>>
>> >>>> On Sat, Feb 10, 2018 at 3:15 AM, Nazeer Hussain Shaik <
>> >>>> nazeerhussain.sh...@gmail.com> wrote:
>> >>>>
>> >>>>> Hi Vishwas,
>> >>>>>
>> >>>>> I can see the below test case failures related to bulk import
>> >>>>> feature(with
>> >>>>> yellow background) which was added recently into Fineract (on both
>> >>>>> Develop
>> >>>>> and 1.1.0 release branch). I don't see any other issue mentioned by 
>> >>>>> you.
>> >>>>>
>> >>>>>   - FixedDepositTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.FixedDepositTe
>> >>>>> st.html>.
>> >>>>>      testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_
>> >>>>> 360_Days
>> >>>>>      <classes/org.apache.fineract.integrationtests.FixedDepositTe
>> >>>>> st.html#testMaturityAmountForDailyCompoundingAndMonthlyPosti
>> >>>>> ng_With_360_Days>
>> >>>>>      - SchedulerJobsTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.SchedulerJobsT
>> >>>>> est.html>.
>> >>>>>       testSchedulerJobs
>> >>>>>      <classes/org.apache.fineract.integrationtests.SchedulerJobsT
>> >>>>> est.html#testSchedulerJobs>
>> >>>>>      - ClientEntityImportHandlerTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.client.ClientEntityImportHandlerTest.html>
>> >>>>>      . testClientImport
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.client.ClientEntityImportHandlerTest.html#testClientImport>
>> >>>>>      - LoanImportHandlerTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.loan.LoanImportHandlerTest.html>
>> >>>>>      . testLoanImport
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.loan.LoanImportHandlerTest.html#testLoanImport>
>> >>>>>      - SavingsImportHandlerTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.savings.SavingsImportHandlerTest.html>
>> >>>>>      . testSavingsImport
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.imp
>> >>>>> orthandler.savings.SavingsImportHandlerTest.html#testSavingsImport>
>> >>>>>      - LoanWorkbookPopulatorTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.pop
>> >>>>> ulator.loan.LoanWorkbookPopulatorTest.html>
>> >>>>>      . testLoanWorkbookPopulate
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.pop
>> >>>>> ulator.loan.LoanWorkbookPopulatorTest.html#testLoanWorkbookPopulate>
>> >>>>>      - SavingsWorkbookPopulateTest
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.pop
>> >>>>> ulator.savings.SavingsWorkbookPopulateTest.html>
>> >>>>>      . testSavingsWorkbookPopulate
>> >>>>>      <classes/org.apache.fineract.integrationtests.bulkimport.pop
>> >>>>> ulator.savings.SavingsWorkbookPopulateTest.html#testSavingsW
>> >>>>> orkbookPopulate>
>> >>>>>
>> >>>>>
>> >>>>> Regards.
>> >>>>> Nazeer
>> >>>>>
>> >>>>>
>> >>>>> On Sat, Feb 10, 2018 at 8:50 AM, Steve Conrad <sconr...@gmail.com>
>> >>>>> wrote:
>> >>>>>
>> >>>>>> Vishwas,
>> >>>>>> Thanks for updating the integration tests relating to the FINERACT-590
>> >>>>>> change. I'll make sure to run integration tests before any promotions.
>> >>>>>> Steve
>> >>>>>>
>> >>>>>>
>> >>>>>> On Fri, Feb 9, 2018 at 8:26 PM, vishwas <
>> >>>>> vish...@confluxtechnologies.com>
>> >>>>>> wrote:
>> >>>>>>
>> >>>>>>> Hi Mexina,
>> >>>>>>>
>> >>>>>>> Many of the failures were related to recent changes made for
>> >>>>>> FINERACT-590.
>> >>>>>>> I have fixed the same now.
>> >>>>>>>
>> >>>>>>> However, I still see 15 failures (details below)
>> >>>>>>>
>> >>>>>>> @Nazeer, Ed, Any devs active on the codebase recently : Do we know
>> >>>>> how
>> >>>>>>> long these test cases have been failing ? Do we having any CI setup
>> >>>>> for
>> >>>>>>> Fineract (we had Travis CI for the erstwhile Mifos codebase, the
>> >>>>> same
>> >>>>>> seems
>> >>>>>>> to be down now) ?
>> >>>>>>>
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest.html>.
>> >>>>>>> testClientUndoRejectWithFutureDate <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrati
>> >>>>> ontests.
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest.html#
>> >>>>>>> testClientUndoRejectWithFutureDate>
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest.html>.
>> >>>>>>> testClientUndoWithDrawnWithFutureDate
>> >>>>> <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrati
>> >>>>> ontests.
>> >>>>>>> ClientUndoRejectAndWithdrawalIntegrationTest.html#
>> >>>>>>> testClientUndoWithDrawnWithFutureDate>
>> >>>>>>> FixedDepositTest <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.FixedDepositTes
>> >>>>> t.html>.
>> >>>>>>> testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_
>> >>>>> 360_Days
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.FixedDepositTest.html#
>> >>>>>>> testMaturityAmountForDailyCompoundingAndMonthlyPosting_With_
>> >>>>> 360_Days>
>> >>>>>>> GroupSavingsIntegrationTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrati
>> >>>>> ontests.
>> >>>>>>> GroupSavingsIntegrationTest.html>. testSavingsAccountCharges
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.
>> >>>>>> GroupSavingsIntegrationTest.
>> >>>>>>> html#testSavingsAccountCharges>
>> >>>>>>> SchedulerJobsTest <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.SchedulerJobsTe
>> >>>>> st.html>.
>> >>>>>>> testSchedulerJobs <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.SchedulerJobsTe
>> >>>>> st.html#
>> >>>>>>> testSchedulerJobs>
>> >>>>>>> SchedulerJobsTestResults <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.integrati
>> >>>>> ontests.
>> >>>>>>> SchedulerJobsTestResults.html>. testApplyDueFeeChargesForSavin
>> >>>>>> gsJobOutcome
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.
>> >>>>>>> SchedulerJobsTestResults.html#testApplyDueFeeChargesForSavin
>> >>>>>> gsJobOutcome>
>> >>>>>>> ClientEntityImportHandlerTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.importhandler.client.
>> >>>>>>> ClientEntityImportHandlerTest.html>. testClientImport
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.bulkimport.
>> >>>>>>> importhandler.client.ClientEntityImportHandlerTest.
>> >>>>>> html#testClientImport>
>> >>>>>>> LoanImportHandlerTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.importhandler.loan.
>> >>>>>> LoanImportHandlerTest.html>.
>> >>>>>>> testLoanImport <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.bulkimport.
>> >>>>>>> importhandler.loan.LoanImportHandlerTest.html#testLoanImport>
>> >>>>>>> OfficeImportHandlerTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.importhandler.office.
>> >>>>>> OfficeImportHandlerTest.html>.
>> >>>>>>> testOfficeImport <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.bulkimport.
>> >>>>>>> importhandler.office.OfficeImportHandlerTest.html#testOfficeImport>
>> >>>>>>> SavingsImportHandlerTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.importhandler.savings.
>> >>>>>>> SavingsImportHandlerTest.html>. testSavingsImport
>> >>>>>>> <applewebdata://25E98590-94EC-47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.bulkimport.
>> >>>>>>> importhandler.savings.SavingsImportHandlerTest.html#testSavi
>> >>>>> ngsImport>
>> >>>>>>> LoanWorkbookPopulatorTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.populator.loan.LoanWorkbookPopul
>> >>>>> atorTest.
>> >>>>>> html>.
>> >>>>>>> testLoanWorkbookPopulate <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.populator.loan.LoanWorkbookPopul
>> >>>>> atorTest.
>> >>>>>>> html#testLoanWorkbookPopulate>
>> >>>>>>> SavingsWorkbookPopulateTest <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.populator.savings.
>> >>>>>> SavingsWorkbookPopulateTest.html>.
>> >>>>>>> testSavingsWorkbookPopulate <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.bulkimport.populator.savings.
>> >>>>>> SavingsWorkbookPopulateTest.
>> >>>>>>> html#testSavingsWorkbookPopulate>
>> >>>>>>> ShareAccountIntegrationTests <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.common.shares.ShareAccountIntegrationTests.html>.
>> >>>>>>> rejectShareAccount <applewebdata://25E98590-94EC-
>> >>>>> 47B7-B872-A1213C63AF43/
>> >>>>>>> classes/org.apache.fineract.integrationtests.common.shares.
>> >>>>>>> ShareAccountIntegrationTests.html#rejectShareAccount>
>> >>>>>>> ShareAccountIntegrationTests <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.common.shares.ShareAccountIntegrationTests.html>.
>> >>>>>>> testShareAccountApproval <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.common.shares.ShareAccountIntegrationTests.
>> >>>>>>> html#testShareAccountApproval>
>> >>>>>>> ShareAccountIntegrationTests <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.common.shares.ShareAccountIntegrationTests.html>.
>> >>>>>>> testShareAccountUndoApproval <applewebdata://25E98590-94EC-
>> >>>>>>> 47B7-B872-A1213C63AF43/classes/org.apache.fineract.
>> >>>>>>> integrationtests.common.shares.ShareAccountIntegrationTests.html#
>> >>>>>>> testShareAccountUndoApproval>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> Regards,
>> >>>>>>> Vishwas
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>> On Feb 8, 2018, at 6:03 AM, Mexina Daniel <mexina@singo.africa>
>> >>>>> wrote:
>> >>>>>>>>
>> >>>>>>>> Hello Devs
>> >>>>>>>>
>> >>>>>>>> What does it mean when the intergration test is failing?
>> >>>>>>>>
>> >>>>>>>> Because i tried to run intergaration test on develop branch and it
>> >>>>>> gives
>> >>>>>>> errors
>> >>>>>>>>
>> >>>>>>>> Regards
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>> Mexina M Daniel
>> >>>>>>>> Lead Software Developer
>> >>>>>>>> Research & Development
>> >>>>>>>>
>> >>>>>>>> Office: +255 22 261 8511 | Mobile: +255 712 110 791
>> >>>>>>>>
>> >>>>>>>> Singo Africa Limited
>> >>>>>>>> Block G, Mbezi Beach B | 7Nakawale Road | P.O BOX 78908 | 14121
>> >>>>> Dar es
>> >>>>>>>> salaam
>> >>>>>>>>
>> >>>>>>>> singo.africa | amala.co.tz
>> >>>>>>>>
>> >>>>>>>> Let's grow together
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>>
>> >>>>
>> >>>> --
>> >>>> *Ed Cable*
>> >>>> President/CEO, Mifos Initiative
>> >>>> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>> >>>> <(484)%20477-8649>
>> >>>>
>> >>>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
>> >>>> <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
>> >>>>
>> >>>>
>> >>>
>> >>
>> >>
>> >> --
>> >> *Ed Cable*
>> >> President/CEO, Mifos Initiative
>> >> edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>> >> <(484)%20477-8649>
>> >>
>> >> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org 
>> >> <http://mifos.org/>
>> >> <http://facebook.com/mifos <http://facebook.com/mifos>>  
>> >> <http://www.twitter.com/mifos <http://www.twitter.com/mifos>>
>> 
> 

Reply via email to